Fix header link #171
Merged
Fix header link #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Tom Whittington <[email protected]>
* fix: feedback link fixed * Fix: Fixed bleeding links --------- Co-authored-by: Tom Whittington <[email protected]>
* feature: setup to use plantechs head and cookies when ran with it * fix: added a title to the gtm iframe * chore: using index reference rather than .First --------- Co-authored-by: Tom Whittington <[email protected]>
* docs: added basic readme file * docs: added testing instruction to README.md --------- Co-authored-by: Tom Whittington <[email protected]>
* Using plantech contentful connection * chore: cleaned up contentful reshuffle --------- Co-authored-by: Tom Whittington <[email protected]>
* feat: made urls use new slug value instead of internal name * chore: cleanedup lint issues * chore: linter issue * fix: updated tests for slug change * fix: updated tests for slug change * feat: now uses csPage heading when no page available or when new useParentHero option is selected in contentful * feat: added unsupported element when item type isn't recognised * Removed tests for removed endpoints * Update src/Dfe.ContentSupport.Web/Views/Shared/_VerticalNavigation.cshtml Co-authored-by: jimwashbrook <[email protected]> * chore: fixed formatting in test * chore: removed redundant case * changes method back to not static and removed Privacy.cshtml --------- Co-authored-by: Tom Whittington <[email protected]> Co-authored-by: jimwashbrook <[email protected]>
…ments chore: Simplify hiding js-only elements
Chore: fix JS linting errors
* feat: changed header logo to go to self-assessment (#153) * Fix/bleeding links (#154) * fix: feedback link fixed * Fix: Fixed bleeding links --------- * fix: added missing span from feedback banner * feature: setup to use plantechs head and cookies when ran with it (#156) * feature: setup to use plantechs head and cookies when ran with it * fix: added a title to the gtm iframe * chore: using index reference rather than .First --------- --------- Co-authored-by: jimwashbrook <[email protected]> Co-authored-by: Tom Whittington <[email protected]>
* Feat: now using keyed services * chore: ran cleanup on new code --------- Co-authored-by: Tom Whittington <[email protected]>
Fix header link
|
katie-gardner
approved these changes
Oct 8, 2024
ThomasWhittington
requested review from
jimwashbrook,
jack-coggin,
Iain-Stanger and
gilaineyo
Iain-Stanger
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per Bug 229132 we want both links to point to the start page as this isn't behind a login